Repository navigation
UI audit pass: accessibility, Back handling, touch targets, contrast - #26
Merged
Merged
Conversation
Audit run with the impeccable (native Android audit) and ui-ux-pro-max skills; findings and scores are in docs/ui-audit-2026-10.md. Systemic: - textMuted #7C7B82 -> #8E8D94: 4.5:1 on card and cardSoft (was 4.1 / 3.7). - Switch rows are one toggleable control (Modifier.switchRow, Role.Switch), so TalkBack reads the label with the state and the label is tappable. - rememberReduceMotion(): looping animations hold still under Remove animations. Platform: - BackHandler for onboarding steps, dashboard edit mode, the live workout (confirm before leaving) and the breathing session (which now saves on exit). - Permissions: ask once per launch instead of on every resume (a dismissed dialog reopened itself); request coarse location with fine; Pairing, onboarding and the barcode scanner handle denial with Open settings. - Confirm before Forget Ring, meal/drink delete, Strava disconnect and coach memory delete. IME padding on settings sub-screens. - runBlocking removed from workout pause/resume/finish. Accessibility: - Labels on icon-only buttons (workout Back/Edit/Delete, duration steppers, drink steppers, nav tabs no longer read twice); selectable/toggleable semantics on chips, segmented controls and radio rows; spoken summaries for charts, gauges, activity rings, the sleep stage bar and the hypnogram; live regions for measurement and coach errors. - 48dp touch targets on edit badges, coach buttons, period chevrons, chips, text links; 9-10sp data labels raised; DEEP stage label off the 2.4:1 indigo. Adaptivity: Today grid goes to three columns from 600dp; buttons use heightIn so large font scales don't clip; Log Meal and record pickers scroll. Removes the unused MeasurementModal.
- Workout pause/resume/finish run on LiveWorkoutManager's own scope. The record screen's scope was cancelled when finishing popped the route, which could drop the Strava auto-upload; a double tap could also finish twice and credit the workout's minutes and distance twice. The finishedSessionId effect alone navigates to the summary now, and Back with no session leaves. - Onboarding: after a Bluetooth denial, "Try again" re-checks the grant, so allowing it in Settings leads back to pairing instead of a dead end. - Today grid: pad short rows to the column count, so a lone tile keeps its width instead of stretching.
DrinksUi.kt conflicted with the Drinks rework (#25). Took main's screen and re-applied the audit's fixes to it: Pill and the tab Segments announce their selection (radio / tab, in selectable groups), the stepper's −/+ name what they change, deleting a recent drink asks first and the icon names the drink, the 3-question check uses one selectable 48dp row per answer, and card titles, stepper notes and recent-drink lines go from 11 to 12sp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A code-level UI audit using the impeccable (native Android audit, scored against Material 3) and ui-ux-pro-max (priority rules + Jetpack Compose guidance) skills. The full report, scores and open items are in
docs/ui-audit-2026-10.md. The GMind brand (dark-only, Ubuntu Mono, mint accent, frame) was treated as the brief, not as a finding.Before: 11/20 (Acceptable). Accessibility 1, Performance 3, Theming 3, Platform conformance 2, Adaptivity 2.
Systemic
textMutedchanges from #7C7B82 to #8E8D94. That brings all 182 uses to 4.5:1 or better oncard/cardSoft(it was 4.1 / 3.7).Modifier.switchRow,Role.Switch). TalkBack reads the label along with the state, and the label is tappable. About 24 sites.rememberReduceMotion(): looping animations stop when Remove animations is on.Platform
runBlockingon the main thread. They run onLiveWorkoutManager's own scope and drop re-entrant taps, so Finish can't credit a workout twice or cancel the Strava upload.Accessibility and layout
heightInso large font scales don't clip.Also removes the unused
MeasurementModal.kt, a zero-height landscape status-bar strip whose insets were already consumed byMainActivity, and ignores.kotlin/.Visible changes to check
Testing
:app:compileDebugKotlinpasses.:app:testDebugUnitTest: 1653 of 1656 pass. The 3 failures fail identically onmain:MealJournalTest×2 (caffeine detection)ResponsesHttpTest.testUnresolvableHostRetriesThenFailsAsTransportGenerated by Claude Code