Repository navigation
Theme: read every colour from the shared design system's GTokens - #55
Merged
Merged
Conversation
PulseColors and FairyMode.Palette held their own Color(0x...) literals. They now read GTokens.kt, generated by the shared design system (gabrielbr/Gabriel-Deisgn-System, layer pulseloop, v0.2.0), so a colour changes in one place for every app. No value changes: the design system's drift.py reports 0 differences, and the screens keep reading PulseColors, so FairyMode works as before. AGENTS.md says where tokens come from now. Claude-Session: https://claude.ai/code/session_01AFTKgVttu8z9Wu34dcvEYY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
PulseColorsandFairyMode.Paletteused to hold their own colour literals: 47 in total. They now readui/theme/GTokens.kt, a file generated by the shared design system (gabrielbr/Gabriel-Deisgn-System, layerpulseloop, v0.2.0). GVoice and GMind use the same design system, so a colour now changes in one place for every app.drift.py --pulseloopreports 0 differences. It compares everyPulseColorsproperty against the token that claims it, whether the property holds a literal or aGTokensreference.PulseColors, neverGTokensdirectly, so Fairy mode's getters work as before.AGENTS.md, under "The design files and the app move together", now says where tokens come from: a colour changes in the design-system repo first, thenGTokens.ktis copied in.Checks run
./gradlew :app:testDebugUnitTest: 1,798 tests, 3 failures. The same 3 fail on the base branch without this change, so they predate this PR:ResponsesHttpTest.testUnresolvableHostRetriesThenFailsAsTransport(needs DNS)MealJournalTestcaffeine-timing tests (they look time-of-day dependent)drift.py --pulseloop: 0 differencesDesign files
The values are unchanged, so the canvas and the design-system artifact need no visual update. Neither link could be opened from this session.
Generated by Claude Code