Skip to content

Follow the design system: three skills, update checksum, one type scale - #59

Merged
gabrielbr merged 1 commit into
mainfrom
ccr-67ccb970-dqwwqd
Nov 4, 2026
Merged

gabrielbr merged 1 commit into
mainfrom
ccr-67ccb970-dqwwqd

Conversation

@gabrielbr

Copy link
Copy Markdown
Owner

Applies the Gabriel Design System's (0.30.0) instructions to PulseLoop retroactively.

Audit: audits/2026-11-04-v2.11.56-design-system.md. It has one section per skill, covers v2.11.50 to v2.11.55 plus this change, and scores 17/20 (up from 13/20). No P0/P1 findings are left open.

Changes

  • Three design skills vendored in .claude/skills/ (impeccable 4.8.0, graphic-design-fundamentals, less-is-more 1.0), with a VENDORED.md that names design system 0.30.0. AGENTS.md now carries the design system's "Three skills on every screen and flow" rule verbatim, plus where the audits go. audits/TEMPLATE.md is copied in.
  • D-11, self-update checksum:
    • release.yml publishes SHA256SUMS.txt.
    • The updater installs only when the APK's SHA-256 matches that file. With no sum, it doesn't install.
    • It refuses a redirect from HTTPS to HTTP.
    • It checks that the APK is the same package, signed with the installed app's key.
  • Update dialog, per docs/self-update.md:
    • The button reads "Update · {size}".
    • Cancel is available while downloading and deletes the partial file. Back and taps outside don't close the dialog mid-download.
    • Failures are reported plainly; all text goes through tr() with pt-BR.
  • One type scale everywhere:
    • 237 off-scale fontSizes in 33 files moved onto 12/14/16/20/24/28/32/40. 65 of them were under the 12sp floor.
    • PulseTypeScaleTest now scans every source, not just 14 files.
  • Postpartum LAM rows: the ✓/✗ glyphs, which showed "good" in mint, are now 22dp line icons in success/warning, with spoken labels.

drift.py --pulseloop: 0 differences, no token changed.

Open, owner's call (design-system repo; this session can't write there)

  • P2-1 / proposed D-13: buttons use Material3's default 40dp height (with a 48dp touch target), not the system's 52dp.
  • D-9: some data colours are shared between metrics.

Note on the first update with this

v2.11.55 has no SHA256SUMS.txt. That doesn't block anyone: the update to this build is installed by the old updater, which doesn't check. From this release on, every release carries the file.


Generated by Claude Code

The Gabriel Design System (0.30.0) asks every app on it to vendor
impeccable, graphic-design-fundamentals and less-is-more, require them
in AGENTS.md, and audit each UI change with all three. PulseLoop had
none of it; this adds it and acts on the retroactive audit
(audits/2026-11-04-v2.11.56-design-system.md).

- .claude/skills/ with VENDORED.md (design system 0.30.0), the rule
  text in AGENTS.md, audits/TEMPLATE.md.
- D-11: releases publish SHA256SUMS.txt; the updater installs only when
  the download matches it, stays on HTTPS, and is this package signed
  with the installed key. The sheet follows docs/self-update.md:
  Update · {size}, Cancel while downloading, honest failures, pt-BR.
- Every fontSize is on PulseType.SCALE (237 moved, 65 were under the
  12sp floor); PulseTypeScaleTest now scans every source.
- Postpartum LAM rows: line icons in success/warning, not mint glyphs.

Claude-Session: https://claude.ai/code/session_01P1t1aUqSUPd3whKXmgVm7w
@gabrielbr
gabrielbr merged commit eb0128b into main Nov 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants