Repository navigation
Every button is a PulseButton, at least 52dp tall - #61
Merged
Merged
Conversation
The design system sets buttons at a 52dp minimum; PulseLoop's were Material3 defaults (40dp, 48dp target). One PulseButton(style, ...) now wraps Filled / Tonal / Outlined / Text with heightIn(min = 52dp) and the 97% press scale, and all 247 direct Material button calls go through it. Fixed 48-56dp heights on buttons are gone; the height is a minimum, so long pt-BR labels grow the button. PulseButtonTest fails on a direct Material button call. Audit: audits/2026-11-04-v2.11.57-pulse-button.md Claude-Session: https://claude.ai/code/session_01P1t1aUqSUPd3whKXmgVm7w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes P2-1 from the v2.11.56 design-system audit. The design system wants every button at least 52dp tall; PulseLoop's were Material3's default 40dp.
Audit:
audits/2026-11-04-v2.11.57-pulse-button.md. It has one section per skill and scores 18/20, with no P0/P1/P2 findings left open.Changes
ui/components/PulseButton.kt: a singlePulseButton(style, onClick, …)with four styles: Filled, Tonal, Outlined and Text.heightIn(min = 52.dp)). Because it's a minimum, not a fixed height, a long pt-BR label or a large font makes the button grow instead of clipping.PulseButtonTestfails if any code calls a Material button directly (Glance widgets are exempt), and it pins the 52dp minimum.Not done in this PR
.btn48px and.btn.sm40px) still need to become 52px.buttonsize token exists only in the uikit layer. I propose moving it to core so PulseLoop's tokens include it. This session can't write to that repo.Generated by Claude Code