Skip to content

Accuracy check grades both rings against the watch - #91

Merged
gabrielbr merged 1 commit into
mainfrom
ccr-67ccb970-dqwwqd
Nov 18, 2026
Merged

gabrielbr merged 1 commit into
mainfrom
ccr-67ccb970-dqwwqd

Conversation

@gabrielbr

Copy link
Copy Markdown
Owner

The owner wears a JRing (main) and a Colmi R06 (comparison) alongside a Huawei watch, and asked for the accuracy check to grade both rings against the watch.

Scoring

AccuracyScorer.scoreComparisonRing runs in the same pass as the main ring, against the same reference data:

  • Heart rate at rest and when active: paired with the reference using the same tolerance and the same rest/active rule (workouts, nights, the main ring's steps).
  • Steps per day: cut to the hours both devices were on, by the main ring's rules.
  • SpO₂: paired within 5 minutes.
  • Sleep: time asleep, fell asleep and woke up, from the comparison ring's per-minute sleep.

The comparison ring's off time comes from its own data, and it is the comparison ring that recorded most during the check (ComparisonDao.mostRecordedAddress).

Isolation

  • Its rows are stored as CMP:<metric> in accuracy_check_days (ComparisonRingScoring.tag). The main ring's report cards, corrections and export pause match exact metric names, so they never see them.
  • Corrections stay the main ring's only.

Report

A new first card, Both rings against [reference]:

  • each ring's typical gap per measure (lower is closer), with the closer value in bold;
  • a one-line tally: "the main ring on N, the second ring on M, about the same on K".

"About the same" means the two gaps are within a fifth of the measure's band or 10 % of each other. The card is absent when no second ring was worn.

Checks

  • Tests: new ComparisonRingScoringTest (tagging and isolation, night onset/wake/asleep, daily steps, the closer rule). Full suite: 2077 tests, the same 3 environment-only failures as main has in this container.
  • Renders: the card was rendered at 1.0× and 1.3× (local harness, not committed). Columns were widened after "22.0 bpm" wrapped at 1.3×.
  • Docs and audit: docs/ring-comparison.md, the AGENTS.md rule updated (the accuracy check now also reads comparison_readings), and audits/2026-11-18-accuracy-both-rings.md.
  • Design canvas: not updated in this PR.

Generated by Claude Code

The owner wears a JRing and a Colmi R06 with a Huawei watch and asked the
accuracy check to grade both. A running check now scores the comparison
ring against the same reference in the same pass: heart rate at rest and
active, steps, SpO2, time asleep, fell asleep and woke up, with its own
off-time gaps and the main ring's rules.

Its rows are stored as CMP:<metric>, so the main ring's report cards,
corrections and export pause never see them. The report opens with "Both
rings against [reference]": each ring's typical gap, the closer one in
bold, and a tally of which ring was closer on how many measures.

Docs: docs/ring-comparison.md, AGENTS.md. Audit:
audits/2026-11-18-accuracy-both-rings.md.

Claude-Session: https://claude.ai/code/session_01P1t1aUqSUPd3whKXmgVm7w
@gabrielbr
gabrielbr merged commit f5d21d1 into main Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants