Open
Conversation
…nstants, few more renames, omitted checking if subtitle is already downloaded - what's the point if new subtitle is already in memory?
…d content returned from NapiProjektApi
…ng of subtitles so they're proper unicodes, added test for the encoding
…lemented taking preferred target encoding instead of hard-coded utf-8
…age in each environment, to be resolved later
…oving file between filesystems now should work)
* implement archive extraction using pylzma instead of using 7z in subprocess, update setup.py * Update README.md * Update setup.py
…ring in github actions CI environment
correct conditional for checking for master branch
…d network share on macOS
…icit requirement for pylzma dependency, bump revision
* fix issues with utf-16 encoded subs * add auto encoding detection using chardet * add chardet as dependency and bump python to 3.7 * bump napi-py to 0.2.3 * add utf-16 test
* test with python 3.11 and 3.12 * bump dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withclause to make sure opened files are closed correctlywindows-1250to unicode, so Linux and non-Polish Windows machines should be able to handle diacritics just fine