Skip to content

Shard splits still failing in production#222

Open
udnay wants to merge 1 commit intomainfrom
yo/relax-wal-uri-check
Open

Shard splits still failing in production#222
udnay wants to merge 1 commit intomainfrom
yo/relax-wal-uri-check

Conversation

@udnay
Copy link
Copy Markdown
Contributor

@udnay udnay commented Apr 2, 2026

Note

Medium Risk
Updates the SlateDB git dependency/branch and switches metric collection to the new DefaultMetricsRecorder snapshot API, which could affect DB initialization and Prometheus storage metrics if the upstream behavior differs.

Overview
Switches the SlateDB dependency to a new git branch and adds an explicit slatedb-common dependency.

Reworks SlateDB observability wiring to use slatedb_common::metrics::DefaultMetricsRecorder: shards now create/retain a recorder and pass it into DbBuilder, and Prometheus export (Metrics::update_slatedb_stats) now reads from recorder snapshots instead of StatRegistry. The server reaper and metrics tests are updated to use the recorder-based path.

Written by Cursor Bugbot for commit aca6c94. This will update automatically on new commits. Configure here.

@udnay
Copy link
Copy Markdown
Contributor Author

udnay commented Apr 2, 2026

This change is part of the following stack:

Change managed by git-spice.

@udnay udnay force-pushed the yo/relax-wal-uri-check branch from c78344c to aca6c94 Compare April 2, 2026 15:38
pub use helpers::now_epoch_ms;

use slatedb::Db;
use slatedb_common::metrics::DefaultMetricsRecorder;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This due to slatedb/slatedb#1460

▎ If users now want metrics they must register their own recorder. They can follow the test examples and use the DefaultMetricsRecorder if they want a simple, lightweight metrics backend.

The design intent is that consumers like silo must pass a MetricsRecorder via DbBuilder::with_metrics_recorder() — there's no longer a built-in always-on recorder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant