Open
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
c78344c to
aca6c94
Compare
udnay
commented
Apr 3, 2026
| pub use helpers::now_epoch_ms; | ||
|
|
||
| use slatedb::Db; | ||
| use slatedb_common::metrics::DefaultMetricsRecorder; |
Contributor
Author
There was a problem hiding this comment.
This due to slatedb/slatedb#1460
▎ If users now want metrics they must register their own recorder. They can follow the test examples and use the DefaultMetricsRecorder if they want a simple, lightweight metrics backend.
The design intent is that consumers like silo must pass a MetricsRecorder via DbBuilder::with_metrics_recorder() — there's no longer a built-in always-on recorder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Updates the SlateDB git dependency/branch and switches metric collection to the new
DefaultMetricsRecordersnapshot API, which could affect DB initialization and Prometheus storage metrics if the upstream behavior differs.Overview
Switches the SlateDB dependency to a new git branch and adds an explicit
slatedb-commondependency.Reworks SlateDB observability wiring to use
slatedb_common::metrics::DefaultMetricsRecorder: shards now create/retain a recorder and pass it intoDbBuilder, and Prometheus export (Metrics::update_slatedb_stats) now reads from recorder snapshots instead ofStatRegistry. The server reaper and metrics tests are updated to use the recorder-based path.Written by Cursor Bugbot for commit aca6c94. This will update automatically on new commits. Configure here.