Enhance SQS monitoring and timeout settings with documentation updates#38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the reliability and accuracy of load test reporting and cleanup for the agentic flavor deployment. The main changes address issues with test harness timeouts, cleanup of incomplete documents, and the clarity of concurrency cap reporting. These updates help ensure that test results more accurately reflect the system's real behavior and reduce the risk of spurious failures due to measurement artifacts.
Load test harness and reporting improvements:
await_completionfunction from 600s to 900s inharness.py, ensuring the harness waits long enough for documents requiring SQS retries to reach a terminal state, thus reducing false timeouts that can fail SLO 1.await_completionto clarify the relationship between the timeout, SQS visibility, and SLO correctness.cleanupfunction inharness.pyto skip deletion of documents still marked astimeout, preventing premature deletion that could cause phantom DLQ failures due to in-flight retries encountering missing S3 objects. Added a printout to inform the user of skipped documents.SLO and concurrency reporting updates:
report.pyto clarify that Lambda concurrency and throttles are the authoritative signals, while SQS in-flight is a noisy proxy now reported for reference but not used for gating. Updated SLO output to include SQS in-flight peak as a proxy value. [1] [2]Documentation and findings: