chore: version packages - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@gaia-react/lint@1.11.0
Minor Changes
#40
1ed4f1bThanks @stevensacks! - Stop ignoring.playwrightand.storybookby default, so theplaywrightandstorybookblocks actually run.Both directories were bare entries in the
ignoresdefaults. A config object carrying onlyignoresis a GLOBAL ignore in flat config, and a global ignore beats any later block'sfiles, so the two blocks that scope themselves to those directories were shadowed by the defaults they shipped alongside.playwrightscopes itself to.playwright/**/*.ts?(x)and never matched a file;storybookkept its*.stories.*rules (those live outside the directory) but its.storybook/main.*rules never ran. The composed config read as though the directories were covered, andpnpm lintreported zero problems for code nothing had checked.The defaults now name only generated output, non-source assets, and tool-owned script directories. A new
ignoressuite asks ESLint which paths survive the defaults, so a future directory-level entry that shadows a scoped block fails a test instead of shipping.playwright/no-skipped-testnow runs withallowConditional: true. A baretest.skip()is a test switched off at author time and stays flagged;test.skip(condition, reason)is Playwright's own API for a test that does not apply to the environment it just found, and flagging it would fail lint on the conditional-skip pattern the recommended set never got to see while the block was inert.Consumers will see new lint errors on upgrade, in e2e specs and their helpers, in Storybook config and decorators, and in anything else living under those two directories. Most are auto-fixable with
--fix. Real findings surface too:playwright/expect-expectandplaywright/no-conditional-in-testhave been configured but inert. To keep a directory exempt, pass it back explicitly: