chore: version packages - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@gaia-react/lint@2.0.0
Major Changes
#42
b364e99Thanks @stevensacks! - React Router relaxations move out ofreactinto a new opt-inreactRouterblock.reactshipped a block scoped to**/routes/**/*.tsxthat turnedno-empty-patternoff. That glob is not unique to React Router: TanStack Router uses aroutes/directory too, so a project on any other file-based router had the rule silently disabled across its whole route tree, with nothing in the composed config explaining why.The relaxation now ships as its own block. Spread it after
reactif you run React Router in framework mode:Breaking for React Router consumers. Without that line,
no-empty-patternreports every route module that destructures nothing from its typed props (({}: Route.ComponentProps)). Adding the spread restores the previous behavior exactly; there is no other migration step. A project that never writes that shape sees no new errors either way, so the upgrade may well be a no-op in practice.Projects on another router should omit it and keep the rule enabled. They will most likely also want to ignore their generated route tree:
The
/.react-router/**glob stays in theignoresdefaults. It names a directory that only exists in a React Router project, so it costs other projects nothing, while moving it would break React Router consumers who miss the new spread.A new suite asks ESLint what the composed config resolves to on both sides of the opt-in, so a future change that folds the block back into
react, or widens its glob, fails a test instead of quietly relaxing a rule.Two dead config entries are removed in the same pass. Neither changes any effective rule:
react/display-namewas set tooffin the route block, butairbnb/config/reactalready sets it toofffor every file.typescript/only-throw-errorblock disabled@typescript-eslint/only-throw-errorforhooks/,routes/, andsessions.server/, but thetypescript/configblock already disables that rule globally for**/*.ts?(x).