feat: remove omnipool stable position #1300
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have not been updated:
Crate versions that have been updated:
Runtime version has been increased. |
Contributor
martinfridrich
left a comment
martinfridrich
left a comment
There was a problem hiding this comment.
There is something wrong with deps.(std), I'm getting:
error[E0433]: failed to resolve: could not find `wasm` in `proc_macro_runtime_interface`
--> /home/frido/.cargo/git/checkouts/polkadot-sdk-0d32aad1614fb5c9/1ed6627/cumulus/primitives/proof-size-hostfunction/src/lib.rs:35:1
|
35 | #[runtime_interface]
| ^^^^^^^^^^^^^^^^^^^^ could not find `wasm` in `proc_macro_runtime_interface`
|
note: found an item that was configured out
...
if I'll do cargo test -p pallet-stableswap or cargo check -p pallet-stableswap
...s/omnipool-liquidity-mining/src/tests/remove_liquidity_stableswap_omnipool_and_exit_farms.rs
Outdated
Show resolved
Hide resolved
martinfridrich
approved these changes
Jan 8, 2026
martinfridrich
requested changes
Jan 8, 2026
Contributor
martinfridrich
left a comment
martinfridrich
left a comment
There was a problem hiding this comment.
Looks good but benchmark it on bench-bot.
|
Quick benchmark at commit 38a604a has been executed successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1294
TODOS: