Iss2509 - Store KeyStore credentials in the CREDS, provide to HTTP/Docker Manager#551
Merged
jadecarino merged 11 commits intogalasa-dev:mainfrom Mar 23, 2026
Merged
Conversation
eamansour
reviewed
Mar 19, 2026
Member
eamansour
left a comment
There was a problem hiding this comment.
Overall looks good! I've added a few thoughts and suggestions to the PR - happy to approve once they're addressed!
eamansour
approved these changes
Mar 23, 2026
…d ETCD credentials, and provided to HTTP Client Manager, allowing Docker Manager to contact protected engines via HTTPS Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
…tore by the REST API Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
…ature Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
…into the Mkdocs website layout, add Windows commands, fix layout issues Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
… if keystore can't be loaded instead of RuntimeException Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
…eTest, replace with mock objects Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
… JSON payload to need a 'base64:' prefix, to reduce chance of user error if users forget to add the prefix Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
…ovided, instead of the code running into a NullPointerException Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
1641dce to
9e72675
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Refer to galasa-dev/projectmanagement#2509
This pull request adds the ability to store a KeyStore credential in the local and ETCD CREDS stores. The purpose of this is to be able to provide that credential to the HTTP Manager so it can use it to set up client authentication with the enclosed certificates. The HTTP Manager can then pass this to the Docker Manager, so it can contact protected Docker engines via HTTPS.
Changes
Framework/Credentials
Managers
REST API
Documentation