James c iss2557 remove scroll logic for test runs#270
Open
James-Cocker wants to merge 3 commits intomainfrom
Open
James c iss2557 remove scroll logic for test runs#270James-Cocker wants to merge 3 commits intomainfrom
James-Cocker wants to merge 3 commits intomainfrom
Conversation
…e last few saved queries Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
eamansour
approved these changes
Mar 9, 2026
Comment on lines
+72
to
+74
| // Recalculate on window resize | ||
| window.addEventListener('resize', calculateMenuDirection); | ||
| window.addEventListener('scroll', calculateMenuDirection); |
Member
There was a problem hiding this comment.
If we add event listeners for each query item, could this impact the page's performance when someone has a lot of saved queries?
Contributor
Author
There was a problem hiding this comment.
I did give it a go and it seemed okay, and it has a massive advantage over hard coding in the last 3 elements as that will depend on screen size and lots of other bits. Do you have another idea? 😁
Member
There was a problem hiding this comment.
Perhaps you could look into using the IntersectionObserver or ResizeObserver APIs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Refer to galasa-dev/projectmanagement#2557.
Removed height restrictions on elements on the
/test-runspage as we can assume users will not have excessive saved queries, and the previous implementation was causing odd scrolling issues.Changes