Skip to content

Refactor Workflow API routes - Part 2 - #17548

Draft
heisner-tillman wants to merge 73 commits into
galaxyproject:devfrom
heisner-tillman:workflows_part_2
Draft

Refactor Workflow API routes - Part 2#17548
heisner-tillman wants to merge 73 commits into
galaxyproject:devfrom
heisner-tillman:workflows_part_2

Conversation

@heisner-tillman

@heisner-tillman heisner-tillman commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

This is a part of #10889 and an extension of #17463.

Summary

  • Refactored API routes:
    • PUT: /api/workflows/menu

      • Added pydantic models to input
      • Added pydantic models to return
      • Removed the mapping to the legacy route
      • Write appropriate tests
    • GET: /api/workflows/download/{workflow_id}, /api/workflows/{workflow_id}/download

      • Added pydantic models to input
      • Added pydantic models to return
      • Removed the mapping to the legacy routes

How to test the changes?

  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    You can find the interactive API documentation here: http://127.0.0.1:8080/api/docs#/workflows
    Screenshot 2024-03-29 at 16-03-07 Galaxy API - Swagger UI

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@heisner-tillman
heisner-tillman marked this pull request as draft February 26, 2024 18:36
@heisner-tillman
heisner-tillman marked this pull request as ready for review February 26, 2024 18:38
@heisner-tillman

Copy link
Copy Markdown
Contributor Author

This is not ready for review. I just wanted to create this pull request such that there is no duplication effort

@jdavcs

jdavcs commented Feb 26, 2024

Copy link
Copy Markdown
Member

This is not ready for review. I just wanted to create this pull request such that there is no duplication effort

Converting to draft.

@jdavcs jdavcs modified the milestones: 24.0, 24.1 Feb 26, 2024
@heisner-tillman
heisner-tillman force-pushed the workflows_part_2 branch 5 times, most recently from 86ee5c7 to 8baee31 Compare March 3, 2024 16:27
@heisner-tillman
heisner-tillman force-pushed the workflows_part_2 branch 4 times, most recently from 5816361 to 29adbd3 Compare March 15, 2024 20:04
@heisner-tillman
heisner-tillman force-pushed the workflows_part_2 branch 4 times, most recently from cb3300c to 3f7b975 Compare March 24, 2024 17:39
@heisner-tillman
heisner-tillman force-pushed the workflows_part_2 branch 2 times, most recently from fd0fd85 to a841862 Compare March 29, 2024 12:01
@heisner-tillman
heisner-tillman marked this pull request as ready for review March 29, 2024 15:05
@heisner-tillman
heisner-tillman force-pushed the workflows_part_2 branch 2 times, most recently from 1aa8ae2 to 08249c0 Compare April 1, 2024 16:57
@jdavcs jdavcs modified the milestones: 24.2, 25.0 Nov 20, 2024
@ahmedhamidawan ahmedhamidawan modified the milestones: 25.0, 25.1 May 7, 2025
@ahmedhamidawan ahmedhamidawan modified the milestones: 25.1, 26.0 Sep 23, 2025
@guerler guerler modified the milestones: 26.0, 26.1 Jan 25, 2026
@guerler guerler added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Jan 25, 2026
@mvdbeek mvdbeek modified the milestones: 26.1, 26.2 May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/API area/testing/api area/testing/integration area/testing kind/refactoring cleanup or refactoring of existing code, no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants