Skip to content

Move BootstrapSize type to shared module #21702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itisAliRH merged 4 commits into from
Jan 30, 2026
Merged

Move BootstrapSize type to shared module #21702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6a6af0
Moves BootstrapSize type to shared module
davelopez Jan 30, 2026
c971e0b
Refactor to use BootstrapSize type for modal size
itisAliRH Jan 30, 2026
1568e47
Refactor TitleSize type to use BootstrapSize for consistency
itisAliRH Jan 30, 2026
51891dd
Add vue3 todo for heading size prop type
itisAliRH Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions client/src/components/Common/GCard.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
import type { SizeProp } from "@fortawesome/fontawesome-svg-core";
import type { IconDefinition } from "@fortawesome/free-solid-svg-icons";

import type { BootstrapVariant } from "@/components/Common";
import type { BootstrapSize, BootstrapVariant } from "@/components/Common";

/** Card badge display styles */
export type CardBadgeType = "pill" | "badge";

/** Bootstrap component sizes */
export type BootstrapSize = "xs" | "sm" | "md" | "lg" | "xl";

/** Title sizes for heading components */
export type TitleSize = "xl" | "lg" | "md" | "sm" | "text";
export type TitleSize = BootstrapSize | "text";

/** Base properties for all card elements */
interface BaseCardElement {
Expand Down
5 changes: 1 addition & 4 deletions client/src/components/Common/GTable.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import type { SizeProp } from "@fortawesome/fontawesome-svg-core";
import type { IconDefinition } from "@fortawesome/free-solid-svg-icons";

import type { BootstrapVariant } from "@/components/Common";

/** Bootstrap component sizes */
export type BootstrapSize = "xs" | "sm" | "md" | "lg" | "xl";
import type { BootstrapSize, BootstrapVariant } from "@/components/Common";

/** Table field sorting order */
export type SortOrder = "asc" | "desc";
Expand Down
3 changes: 2 additions & 1 deletion client/src/components/Common/Heading.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ interface Props {
bold?: boolean;
separator?: boolean;
inline?: boolean;
size?: "xl" | "lg" | "md" | "sm" | "text";
// TODO: Redo in Vue 3 to use BootstrapSize for prop typing.
size?: "xs" | "sm" | "md" | "lg" | "xl" | "text";
icon?: IconLike;
truncate?: boolean;
collapse?: "open" | "closed" | "none";
Expand Down
3 changes: 3 additions & 0 deletions client/src/components/Common/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ export type BootstrapVariant =
| "outline-link"
| "outline-dark";

/** Bootstrap component sizes */
export type BootstrapSize = "xs" | "sm" | "md" | "lg" | "xl";

/**
* Represents a breadcrumb item in the BreadcrumbHeading component.
* Each item can have a title, an optional URL to navigate to, and optional additional text
Expand Down
6 changes: 3 additions & 3 deletions client/src/composables/confirmDialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { type Ref, ref } from "vue";

import type { BootstrapVariant } from "@/components/Common";
import type { BootstrapSize, BootstrapVariant } from "@/components/Common";

/**
* Bootstrap Vue modal message box options interface.
Expand All @@ -25,7 +25,7 @@ export interface ConfirmDialogOptions {
* Modal size: 'sm', 'lg', 'xl'
* @default undefined (medium)
*/
size?: "sm" | "lg" | "xl";
size?: BootstrapSize;
/**
* Center modal vertically
* @default true
Expand Down Expand Up @@ -60,7 +60,7 @@ export interface ConfirmDialogOptions {
* Footer button size: 'sm', 'lg'
* @default undefined (normal)
*/
buttonSize?: "sm" | "lg";
buttonSize?: BootstrapSize;
/**
* Hide header close button
* @default false
Expand Down
Loading