[26.1] Add kraken2 datatype - #22455
Draft
pvanheus wants to merge 9 commits into
Draft
Conversation
mvdbeek
reviewed
Apr 15, 2026
mvdbeek
marked this pull request as draft
April 15, 2026 07:56
Contributor
Author
|
Update from GCC 2026 - this now uses only subclasses, so only changes the Wins and losses:
|
| @@ -360,6 +359,12 @@ | |||
| <datatype extension="tar" auto_compressed_types="gz,bz2" type="galaxy.datatypes.binary:CompressedArchive" subclass="true" display_in_upload="true"> | |||
| <converter file="archive_to_directory.xml" target_datatype="directory"/> | |||
| </datatype> | |||
| <datatype extension="kraken2db.tar" auto_compressed_types="gz,bz2" type="galaxy.datatypes.binary:Binary" subclass="true" display_in_upload="true" description="Kraken2 database archive"> | |||
| <converter file="archive_to_directory.xml" target_datatype="kraken2db"/> | |||
Contributor
There was a problem hiding this comment.
Does this really work? That is does it produce a kraken2db or a directory.
| <converter file="archive_to_directory.xml" target_datatype="kraken2db"/> | ||
| </datatype> | ||
| <datatype extension="kraken2db" type="galaxy.datatypes.data:Directory" subclass="true" description="Kraken2 database directory"> | ||
| <converter file="directory_to_archive.xml" target_datatype="kraken2db.tar.gz"/> |
Contributor
There was a problem hiding this comment.
Would this convert any directory?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update in galaxyproject/tools-iuc#7257 for the kraken2 tool allows it to use a custom database passed as a parameter. Currently this uses the Directory datatype. This datatype allows a more specific input type to be specified and also allows a compressed archive to be uploaded and unpacked to the kraken2 database datatype.
How to test the changes?
(Select all options that apply)
License