Migrate remaining BAlert call sites to GAlert - #22703
Open
dannon wants to merge 15 commits into
Open
Conversation
dannon
force-pushed
the
feature/g-alert-sweep
branch
from
May 24, 2026 17:26
6138177 to
4354d95
Compare
dannon
force-pushed
the
feature/g-alert-sweep
branch
from
June 1, 2026 21:16
4354d95 to
507588c
Compare
dannon
force-pushed
the
feature/g-alert-sweep
branch
from
July 30, 2026 00:02
507588c to
7ff5c14
Compare
dannon
force-pushed
the
feature/g-alert-sweep
branch
from
August 19, 2026 19:11
7ff5c14 to
9c042bd
Compare
dannon
marked this pull request as ready for review
August 24, 2026 01:11
dannon
force-pushed
the
feature/g-alert-sweep
branch
from
August 24, 2026 01:18
9c042bd to
6accc62
Compare
vue-tsc on the sweep PR flagged 13 call sites where the variant prop is a
dynamic string (or the literal "error", or null) and one where show is
string|null|undefined -- all of which BAlert silently accepted but GAlert's
stricter unions reject. Widen variant to include `(string & {}) | null` so
IDE autocomplete still suggests the recommended values without forcing
casts on existing call sites, add null to AlertShow, and fall back to the
default info variant when variant is null/empty. Also explicitly guard
null in parseShow/parseCountDown/hasNumericShow -- the latter is a real
correctness fix, since Number(null) === 0 would otherwise have flipped
GAlert into countdown mode.
These files were added on dev after the initial sweep was cut, so they still imported BAlert. Same straightforward swap as the earlier batches.
The history graph and page editor both grew new BAlert call sites while this branch sat, so pick those up here rather than leave the sweep half finished. Same mechanical swap as the area commits: drop BAlert from the bootstrap-vue import, pull in GAlert, translate the tag. The three PageEditor tests that matched on `balert-stub` now look for `galert-stub`, since HistoryPageView and PageEditorView are migrated.
dannon
force-pushed
the
feature/g-alert-sweep
branch
from
August 26, 2026 17:35
6accc62 to
6ea0f26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up where #22687 left off and migrates the rest of the BAlert call sites to GAlert. Part of the bootstrap-vue scoped-slot replacement effort in #21956 and the Vue 3 push in #20787.
First commit extends GAlert to cover the BAlert features I deferred the first time around -- numeric
showcountdown (withdismiss-count-down), default v-model (Vue 2value/inputand Vue 3modelValue), and an explicitname: "GAlert"so shallow stubs resolve cleanly in tests. Ten commits then sweep area by area: admin, history, workflow, collections/libraries, tool-facing, forms/config, data/storage, user flows, content rendering, shared wrappers. The rest clean up after -- ~15 tests that were still poking atBAlertorbalert-stub, a prop-type loosening so the permissive call sites (dynamic-string variant, null) still type-check, and the PageEditor/StorageOperations stragglers.This one sat for a while, so the last commit is the rebase catching up with
dev. The history graph and page editor both grew new BAlert call sites in the meantime, and three tests ondevwere selecting onbalert-stubfor components this PR migrates -- rather than leave the sweep half finished I did those too, same mechanical swap. A few filesdevhad already migrated or restructured around in the meantime,Workflow/Import/FromFile.vuemost notably, I just took as they are.Residual scan turns up nothing -- the only
BAlerttoken left inclient/srcis the explanatory comment in GAlert.vue. Client suite passes in CI at 382 files / 2664 tests, andtype-checkoutput is unchanged fromdev.No bootstrap-vue dep or CSS goes away here -- alerts still use the bootstrap
.alert*styles. More bootstrap-vue removals will keep landing as the replacements ship.