Migrate obfs datatype from basic to auto_primary_file composite type - #23366
Merged
Conversation
The OpenBabel Fastsearch (obfs) datatype was registered with
composite_type='basic', but the upload pipeline (galaxy/tools/data_fetch.py)
only supports 'auto_primary_file' composites -- 'basic' composites trigger
an unimplemented assertion ('basic composite uploads not yet implemented').
This blocked the obfs datatype from being assembled as a tool input in the
test framework, forcing downstream tools that consume obfs (openbabel
subsearch, simsearch) to use expect_failure tests that never actually
exercise the tool.
The obfs primary file is a 0-byte placeholder; the real data lives entirely
in the composite extra files (molecule.fs and the molecule source file),
which is exactly the auto_primary_file pattern. Switch the composite type
and add generate_primary_file/regenerate_primary_file to produce an HTML
index page, following the established pattern (e.g. spaln, gis, neo4j).
bgruening
force-pushed
the
obfs-auto-primary-file
branch
from
August 25, 2026 19:43
2f7db69 to
61d305d
Compare
Convert the .format() call to an f-string. Only lint change; ruff check ., flake8, isort and black are all clean afterward. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G95icoGkoDKbwPotGnvQpk
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
|
This PR was merged without a "kind/" label, please correct. |
nsoranzo
added
the
kind/refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the
obfs(OpenBabel Fastsearch) datatype fromcomposite_type='basic'tocomposite_type='auto_primary_file'.The basic composite datatype can not be tested I think. And this is ok, for this niche use-case.