Forward force_path_paste for non-composite test inputs - #23401
Open
afgane wants to merge 1 commit into
Open
Conversation
afgane
force-pushed
the
fix-remote-to-input-force-path-paste
branch
from
August 28, 2026 18:01
19f42c1 to
a120563
Compare
jmchilton
approved these changes
Sep 4, 2026
jmchilton
left a comment
Member
There was a problem hiding this comment.
It is conflicted and needs a rebase or merge - but it is ready to be merged after that.
remote_to_input() passes force_path_paste to _get_path_or_location() on its composite_data branch but not on the branch immediately below it, so galaxy-tool-test's --force_path_paste has been silently ignored for ordinary single-file inputs - the far commoner case. Those inputs fall through to the client-upload path regardless of the flag. Add the missing keyword argument, and cover both branches with tests. The tests record what _get_path_or_location is called with rather than standing up an interactor, since none of GalaxyInteractorApi's connection setup is relevant to argument forwarding. Confirmed they fail against the current code and pass with the fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
afgane
force-pushed
the
fix-remote-to-input-force-path-paste
branch
from
September 5, 2026 02:54
a120563 to
3b0b745
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
remote_to_input()passesforce_path_pasteto_get_path_or_location()onits
composite_databranch, but not on the branch immediately below it:So
galaxy-tool-test --force_path_pastehas been silently ignored for ordinarysingle-file inputs — the far commoner case — and those inputs fall through to
the client-upload path regardless of the flag.
Fix
Add the missing keyword argument.
Tests
There was no coverage of
force_path_pasteanywhere, so this adds twoparametrised tests in
test/unit/tool_util/verify/test_interactor.py, one perbranch, since the bug is precisely that the two branches disagree. They record
what
_get_path_or_locationis called with rather than standing up aninteractor, as none of
GalaxyInteractorApi.__init__'s connection setup isrelevant to argument forwarding.
Verified on Python 3.10 that the non-composite pair fails without the fix and
passes with it, while the composite pair passes either way.