Migrate ToolForm to Composition API and TypeScript - #23450
Open
ahmedhamidawan wants to merge 11 commits into
Open
Migrate ToolForm to Composition API and TypeScript#23450ahmedhamidawan wants to merge 11 commits into
ToolForm to Composition API and TypeScript#23450ahmedhamidawan wants to merge 11 commits into
Conversation
Also console warns on the search scroll errors, no need to toast those as those are retried and repetitive on scroll.
We do so because we allow user to navigate away after submitting job. if they don't that's when we route to the success page.
Co-Authored-By: Claude <noreply@anthropic.com>
ahmedhamidawan
added
area/UI-UX
kind/refactoring
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintains existing functionality as is, updates the vitest. Adds some types like
ToolFormConfigwhich is the expected tool-form "build" model returned byupdateToolFormData/getToolFormDatainclient/src/components/Tool/services.js(POST or GET/api/tools/{id}/build, or/api/jobs/{jobId}/build_for_rerun).How to test the changes?
(Select all options that apply)
License