Reject output-only format_source references in the XML linter - #23459
Open
jmchilton wants to merge 2 commits into
Open
Reject output-only format_source references in the XML linter#23459jmchilton wants to merge 2 commits into
jmchilton wants to merge 2 commits into
Conversation
mvdbeek
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the XML linter exemption that treated an output name as a valid
format_sourcereference.At runtime, output formats can be derived from tool inputs and input collections, but not from another output. The schema likewise documents
format_sourceas an input reference. Restricting the linter to collected input parameter paths makes linting consistent with those semantics.Fixes #23449.
How to test the changes?
format_source.Existing linter suite:
pytest test/unit/tool_util/test_tool_linters.py(104 passed).License