Draft
Conversation
galister
reviewed
Mar 9, 2025
galister
reviewed
Mar 9, 2025
Owner
|
Might want to check out what WayVR does; WayVR's Smithay library works with GLES/EGL, so the GL texture is exported via DMA-buf before it's finally imported as a VkImage. |
Author
Thanks, I'll look into this. Also, I just tested with WayVR and wlx-overlay-s crashes when opening the dash if NvFBC is picked over Xshm or Pipewire. This issue seems related: timothee-haudebourg/khronos-egl#25 |
57ef78b to
f3119c5
Compare
f3119c5 to
6e53c35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Nvidia Framebuffer Capture support on X11 using this wrapper.
This PR still copies to the framebuffer to system memory, but it's still noticeably a lot faster than Xshm, but NvFBC does support copying into a OpenGL texture, but copying to system memory first seems fast enough in wlx-overlay-s.
The other issue is that this NvFBC wrapper package doesn't seem to support capturing from other monitors besides the first one, but I think I must be doing something wrong. I haven't tested this with multiple monitors.
The capture frame rate is also currently hardcoded and it should probably match the monitor refresh rate or the headset refresh rate, which ever is lower.
Meant to be used with wlx-team/wayvr#173