Fixed cue magnitude reentracy. - #67
Merged
Merged
Conversation
Fire cues before executed/changed hooks so a hook re-applying an effect to the target can't flush the deltas AttributeValueChange cues read.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Cue callbacks can now mutate or remove effects before their lifecycle components process the original operation.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Reorders cue dispatch so attribute-change magnitudes are read before reentrant effect hooks can flush pending deltas.
Changes:
- Executes cues before effect-executed and active-effect-changed hooks.
- Adds regression tests for both execution and stacking updates.
| File | Description |
|---|---|
Forge/Effects/EffectsManager.cs |
Reorders execution cues before hooks. |
Forge/Effects/ActiveEffect.cs |
Reorders stacking-update cues before change hooks. |
Forge.Tests/Cues/CueMagnitudeReentrancyTests.cs |
Tests reentrant cue magnitudes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Read cue magnitudes before the hooks but dispatch the handlers after them, so components and changed callbacks keep running first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fire cues before executed/changed hooks so a hook re-applying an effect to the target can't flush the deltas AttributeValueChange cues read.