Set async meta on yCursorPlugin transactions - #34
Merged
Conversation
juliebarwick
approved these changes
Jul 10, 2026
|
Looks good, but requesting @jamesopti to verify too since this is in such a commonly used file. |
jamesopti
reviewed
Jul 10, 2026
| metas.forEach((val, key) => { | ||
| tr.setMeta(key, val) | ||
| }) | ||
| tr.setMeta('async', true) |
There was a problem hiding this comment.
LGTM assuming we checked that there isn't a namespace conflict for async currently. I doubt it!
There was a problem hiding this comment.
Also checked with @angelaguo and this is only used in the y-cursor plugin so doubly safe.
jamesopti
approved these changes
Jul 10, 2026
juliebarwick
approved these changes
Jul 10, 2026
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set metadata on yCursorPlugin transactions to tell react-prosemirror to skip flushSync for them. (Corresponding functionality added to react-prosemirror here). These transactions are consistently firing in between DOM selection updates and the browser firing the corresponding selectionchange event, which is causing selection reversions in Gamma