fix: failing CI

Gemfile.lock

@@ -113,7 +113,7 @@ GEM
     bindex (0.8.1)
     bootsnap (1.18.4)
       msgpack (~> 1.2)
-    brakeman (7.0.2)
+    brakeman (7.1.1)
       racc
     builder (3.3.0)
     capybara (3.40.0)

app/models/game_question.rb

@@ -52,13 +52,14 @@ def reward_players_if_completed
     all_players.find_each do |player|
       current_question_answer = player.player_answers.find_by(game_question_id: id)
       unless current_question_answer
-        player.player_answers.create(game_question: self, answer_id: -1, correct: false)
+        # player did not answer
+        player.player_answers.create!(game_question: self, answer_id: PlayerAnswer::NO_ANSWER_ID, correct: false)
       end
 
       if current_question_answer&.correct
         player.award_points!(question.points, current_question_answer.time_taken)
       else
-        player.update(current_streak: 0)
+        player.update!(current_streak: 0)
       end
     end
 

app/models/player_answer.rb

@@ -21,6 +21,8 @@
 #
 class PlayerAnswer < ApplicationRecord
 
+  NO_ANSWER_ID = -1
+
   belongs_to :answer, optional: true
   belongs_to :game_player
   belongs_to :game_question
@@ -30,7 +32,7 @@ class PlayerAnswer < ApplicationRecord
   private
 
   def not_created_or_updated_after_game_question_completed
-    return unless game_question.completed?
+    return if !game_question.completed? || answer_id == NO_ANSWER_ID
 
     errors.add(:base, "cannot set or change answer after question completed")
   end

test/controllers/game_player_answers_controller_test.rb

@@ -7,8 +7,8 @@ class GamePlayerAnswersControllerTest < ActionDispatch::IntegrationTest
   setup do
     @user = users(:one)
     @game = games(:one)
-    @game_question = game_questions(:one)
-    @correct_answer = answers(:correct)
+    @game_question = game_questions(:two)
+    @correct_answer = answers(:two)
     @incorrect_answer = answers(:incorrect)
     @game_player = game_players(:one)