Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220.
Ultrawide recordings used to go to ganked.tv whole and get cropped there. The editor now has a crop rectangle over the preview, and Save, Save as copy and Upload write only that region.
What's in it
crop.rs: the pure crop math (normalized rect, presets Original / 16:9 / 21:9 / 4:3 / 9:16 / Free, ratio-locked resize with anchored edges, even-pixel snapping for yuv420p), ported from ganked.tv's cropper with its test suite.cropbox.rs: the overlay widget stacked over the preview and the fullscreen view. Eight handles, body drag, arrows move, shift+arrows resize, esc resets. It draws over the same contain rect the video shader uses, so the detail-page still switched from Cover to Contain.export.rs: the one re-encode path in the app, through the bundled ffmpeg: trim and crop in one pass, libx264 at CRF 18 / veryfast, audio copied, progress on stdout, cancellable. Trim-only stays the lossless stream copy.TRIM & CROPpanel with progress and Cancel, upload crops locally first. The rectangle is editor state like the trim range, not persisted.chunks_exactlints the current stable clippy raises, so CI stays green when it moves.Verified
cargo test --workspace,cargo clippy --workspace --all-targets -- -D warnings,rustfmt --checkover every crate: green.#[ignore]tests (real export of a synthesised clip, read back through our MP4 reader and the openh264 thumbnail path; upload crop temp) pass against ffmpeg 9.