Skip to content

Swap binance#22

Open
BastienLopez wants to merge 4 commits into
garagesteve1155:mainfrom
BastienLopez:swap_binance
Open

Swap binance#22
BastienLopez wants to merge 4 commits into
garagesteve1155:mainfrom
BastienLopez:swap_binance

Conversation

@BastienLopez

Copy link
Copy Markdown

No description provided.

@albuckley

Copy link
Copy Markdown

The API key and secret should not be stored in a configuration file the way you have done.

It should be isolated and loaded from a file that is not tracked, ideally outside this source tree altogether and encrypted.

@b1ackm0x

Copy link
Copy Markdown

Yeah this guy is not very brilliant, he wont merge code, doesn't use encryption for API's amongst many other things.
Its the METH-od he chose.

@b1ackm0x

Copy link
Copy Markdown

from cryptography.fernet import Fernet

@GhackASTech

GhackASTech commented Jan 14, 2026 via email

Copy link
Copy Markdown

@albuckley

albuckley commented Jan 14, 2026 via email

Copy link
Copy Markdown

@b1ackm0x

b1ackm0x commented Jan 19, 2026 via email

Copy link
Copy Markdown

@albuckley

albuckley commented Jan 20, 2026 via email

Copy link
Copy Markdown

@b1ackm0x

Copy link
Copy Markdown

To be honest that's why I spammed the shit out him, I am drizztdowhateva, I believe in freedom of speech and open source code wholeheartedly, I told him that if anything ever came of it that I would give him 10% guaranteed because I believe in a handshake and I literally said it in the Facebook forums. Oh well no such thing as bad publicity.

I have two different accounts one for my legitimate business with an Incorporation, and this one. Drizzt is from the Forgotten Realms series, but anyways yeah, I think the guy isn't willing to play nice with the whole concept of GitHub, which frustrates me highly. Not to mention, he's not willing to admit the shortcomings and take professional help.

He will block me at this point and try to censor this, but we are the real gate keepers, and I felt the same way that you do. I've been doing this shit since 300 baud modems, ran my own bulletin board service, and used to freak Ma Bell all the way up to recording coin tones at 2600hz. Either this kid is hiding something in his code(beside slop) or he's incredibly naive.

Anyways enough of stupid flexes, people that use GitHub but refuse any other Improvement is hypocrisy. That's what git hub exists for.

On the other hand I've moved on to a program that I designed that helps people merge the ZIP code into their ham radio. In general people don't trust a guy named garage Steve with their money. Just saying.

Not to mention he's been talking about making a cash option or something of that sort, it's called a dry run dummy, simulation? And I don't think anything is getting lint or smoke tested. The scaffolding is subpar. Also he did not see the benefit of running it on Mac OS and Linux, windows was as only interest if you look at the code, all the paths are hard coded. 🤔

He said he won't take any pull requests?

Lmao

That actually motivates me to fork it and make it better.

On Mon, 19 Jan 2026, 10:49 pm b1ackm0x, @.***> wrote:

b1ackm0x left a comment (#22)
#22 (comment)
Not to mention, the API is unencrypted, which took a simple line of code.
And
this dude has already said that he won't accept anyone else's code.

Kind of counterintuitive my opinion. Some of the trading data is actually
trading off from history instead of current.

The project also could be multi-threaded so every coin trains at the same
time instead of one after another which ends up taking all day especially
if you have 10 coins.

The whole thing is really sloppy and fits the name garage Steve.

On Wed, Jan 14, 2026, 2:47 PM albuckley @.***> wrote:

albuckley left a comment (#22)
<
https://github.com/garagesteve1155/PowerTrader_AI/pull/22#issuecomment-3751650613>

I see the value in the code but I don't think it can be extended until
the
main application file is refactored, broken down into components and
implements OOP.

If anyone tried to extend it now, all the effort would be rendered
useless
if someone did the reorganisation. The main file is a dumping ground of
random methods. They all need to be categorised and separated into
different files.

Ironically, ai could do that job in minutes. Just needs someone with
professional software engineering experience to drive that.

I have to will to do it myself but it is crunch time at work so I can't
look at this for the time being.

I reviewed the code but couldn't make any assessment of the rigor of the
application or algorithms as its all just mixed up with trivial
supporting
methods.

That all has to be cleaned up before anyone can see if there are any
financial risks due to bugs or other errors.

On Wed, Jan 14, 2026 at 7:44 PM GhackASTech @.***>
wrote:

GhackASTech left a comment (#22)
<

https://github.com/garagesteve1155/PowerTrader_AI/pull/22#issuecomment-3751314984>

Is it a fork that uses Binance API with paper trading ? probably built
it
AI and has lots of bugs

On Wed, Jan 14, 2026, 6:34 PM b1ackm0x @.***> wrote:

b1ackm0x left a comment (#22)
<

https://github.com/garagesteve1155/PowerTrader_AI/pull/22#issuecomment-3751029059>

from cryptography.fernet import Fernet


Reply to this email directly, view it on GitHub
<

https://github.com/garagesteve1155/PowerTrader_AI/pull/22#issuecomment-3751029059>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXXAI4ZJAYNVZPSIESV7HPL4G2D3HAVCNFSM6AAAAACQVNWZ6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONJRGAZDSMBVHE>

.
You are receiving this because you are subscribed to this
thread.Message
ID: @.***>


Reply to this email directly, view it on GitHub
<

https://github.com/garagesteve1155/PowerTrader_AI/pull/22#issuecomment-3751314984>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/ABKFE2TFCXPO5GKMLMH6NED4G2MDHAVCNFSM6AAAAACQVNWZ6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONJRGMYTIOJYGQ>

.
You are receiving this because you commented.Message ID:
@.***>


Reply to this email directly, view it on GitHub
<
https://github.com/garagesteve1155/PowerTrader_AI/pull/22#issuecomment-3751650613>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/BIEVIXQSGAOJDXHB36GRI6T4G2TNPAVCNFSM6AAAAACQVNWZ6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONJRGY2TANRRGM>

.
You are receiving this because you commented.Message ID:
@.***>


Reply to this email directly, view it on GitHub
#22 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKFE2WRKKMWPV3DE2GRJV34HVNQZAVCNFSM6AAAAACQVNWZ6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONZQGM2TENZTGA
.
You are receiving this because you commented.Message ID:
@.***>

@albuckley

albuckley commented Jan 28, 2026 via email

Copy link
Copy Markdown

Ibrahim-3d added a commit to Ibrahim-3d/PowerTraderAI that referenced this pull request Feb 7, 2026
- Credit original author (garagesteve1155) at the top
- Document what this fork changes vs upstream
- Reference upstream issues addressed (garagesteve1155#22, garagesteve1155#29, garagesteve1155#34, garagesteve1155#35)
- Replace Robinhood setup instructions with Binance
- Add batch launcher quick-start table
- Document new training UX features (skip-trained, resume, progress bar)
- Add architecture overview and git clone instructions

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants