Skip to content

Fix: Tweak link transformation for absolute paths in source repo - #20

Closed
ByteOtter wants to merge 3 commits into
mainfrom
fix/fix-asset-links
Closed

ByteOtter wants to merge 3 commits into
mainfrom
fix/fix-asset-links

Conversation

@ByteOtter

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Tweaks link transformation to deal with absolute paths in source repo for media.
Relative paths have proven to be too flaky for the approach we chose for documentation. I have fixed this manually in the gardenlinux repo by switching to absolute path for media assets in gardenlinux/gardenlinux@c4b1d8d

Which issue(s) this PR fixes:
Fixes n/A

Definition of Done:

  • The code is sufficiently documented
  • Shared the changes with the Team so everyone is aware
  • The code is appropriately tested
  • Checked if the code needs to be backported to release branches of maintained versions (perform the actual backport after the merge to main)

@netlify

netlify Bot commented Mar 30, 2026

Copy link
Copy Markdown

Deploy Preview for gardenlinux-docs failed.

Name Link
🔨 Latest commit 4f95e53
🔍 Latest deploy log https://app.netlify.com/projects/gardenlinux-docs/deploys/69ca8c550e285b00070c8917

@ByteOtter
ByteOtter force-pushed the fix/fix-asset-links branch 2 times, most recently from 5344e96 to 0baa0c1 Compare March 30, 2026 14:33
@ByteOtter
ByteOtter force-pushed the fix/fix-asset-links branch from 0baa0c1 to 4f95e53 Compare March 30, 2026 14:44
@yeoldegrove

Copy link
Copy Markdown
Contributor

@ByteOtter Is this ready to review or do we need changes after our last discussions?

@ByteOtter

Copy link
Copy Markdown
Collaborator Author

@ByteOtter Is this ready to review or do we need changes after our last discussion

Well it still doesnt work 100 percent so Im gonna continue working on this

@ByteOtter

Copy link
Copy Markdown
Collaborator Author

obsoleted by #26 from what I can tell

@yeoldegrove yeoldegrove closed this Apr 2, 2026
@yeoldegrove
yeoldegrove deleted the fix/fix-asset-links branch April 15, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants