Skip to content

Refactor: Generalize Engine Nomenclature and Sync with Protocol#65

Merged
garnizeh-labs merged 3 commits into
mainfrom
refactor/generalize-engine
May 14, 2026
Merged

Refactor: Generalize Engine Nomenclature and Sync with Protocol#65
garnizeh-labs merged 3 commits into
mainfrom
refactor/generalize-engine

Conversation

@garnizeh

Copy link
Copy Markdown
Collaborator

This PR synchronizes the engine with the generalized protocol nomenclature (Room -> Workspace, Ship -> Agent) and fixes OpenTelemetry dependency version mismatches.

Key changes:

  • Renamed core concepts in ECS components and systems.
  • Updated protocol dependencies to v0.2.23.
  • Downgraded opentelemetry crates to 0.31.0 to resolve trait bound errors with tracing-opentelemetry.
  • Fixed async disconnect calls in integration tests.
  • Verified with 'just check'.

@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@garnizeh has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 39 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7ba93378-8950-4b19-8420-9de768925a83

📥 Commits

Reviewing files that changed from the base of the PR and between 0b1b1d4 and 90a73a0.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (23)
  • Cargo.toml
  • crates/aetheris-ecs-bevy/benches/ecs_pipeline.rs
  • crates/aetheris-ecs-bevy/src/adapter.rs
  • crates/aetheris-ecs-bevy/src/combat.rs
  • crates/aetheris-ecs-bevy/src/components.rs
  • crates/aetheris-ecs-bevy/src/extraction.rs
  • crates/aetheris-ecs-bevy/src/interaction.rs
  • crates/aetheris-ecs-bevy/src/lib.rs
  • crates/aetheris-ecs-bevy/src/mining.rs
  • crates/aetheris-ecs-bevy/src/physics_consts.rs
  • crates/aetheris-ecs-bevy/src/registry.rs
  • crates/aetheris-ecs-bevy/tests/combat_tests.rs
  • crates/aetheris-server/benches/tick_pipeline.rs
  • crates/aetheris-server/src/lib.rs
  • crates/aetheris-server/src/main.rs
  • crates/aetheris-server/src/multi_transport.rs
  • crates/aetheris-server/src/tick.rs
  • crates/aetheris-server/tests/determinism.rs
  • crates/aetheris-server/tests/security_integration.rs
  • crates/aetheris-server/tests/server_integration.rs
  • crates/aetheris-stress/src/main.rs
  • crates/aetheris-transport-renet/src/lib.rs
  • crates/aetheris-transport-webtransport/src/lib.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/generalize-engine

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@garnizeh-labs
garnizeh-labs merged commit ee1614b into main May 14, 2026
9 checks passed
@garnizeh-labs
garnizeh-labs deleted the refactor/generalize-engine branch May 14, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants