Skip to content

docs: fix fano amplitude docstring, list missing exports, fix scratch script - #7

Merged
garrekstemo merged 1 commit into
mainfrom
fix/post-refactor-consistency
Jun 22, 2026
Merged

docs: fix fano amplitude docstring, list missing exports, fix scratch script#7
garrekstemo merged 1 commit into
mainfrom
fix/post-refactor-consistency

Conversation

@garrekstemo

Copy link
Copy Markdown
Owner

Part of the post-refactor full-stack consistency pass (read-only multi-agent audit → 67 confirmed findings). Full test suite green locally. Details in the commit body.

… script

- fano docstring: `A` is a scale factor, not the peak height — the value at x₀
  is A·q² and the profile maximum is A·(1+q²).
- README: add the exported `voigt`, `fano`, `log_normal` lineshapes to the list.
- scratch/generate_readme_plot.jl: call `lorentzian` (the real function, same
  FWHM parameterization), not the non-existent `lorentzian_fwhm`.
- codecov-action v5 → v7 (stack-wide unification).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@garrekstemo
garrekstemo merged commit 1c6da68 into main Jun 22, 2026
3 checks passed
@garrekstemo
garrekstemo deleted the fix/post-refactor-consistency branch June 22, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant