docs: fix fano amplitude docstring, list missing exports, fix scratch script - #7
Merged
Merged
Conversation
… script - fano docstring: `A` is a scale factor, not the peak height — the value at x₀ is A·q² and the profile maximum is A·(1+q²). - README: add the exported `voigt`, `fano`, `log_normal` lineshapes to the list. - scratch/generate_readme_plot.jl: call `lorentzian` (the real function, same FWHM parameterization), not the non-existent `lorentzian_fwhm`. - codecov-action v5 → v7 (stack-wide unification). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the post-refactor full-stack consistency pass (read-only multi-agent audit → 67 confirmed findings). Full test suite green locally. Details in the commit body.