fix source routing for import and search#1168
Closed
tyad67-netizen wants to merge 1 commit into
Closed
Conversation
fc143bb to
3052c3b
Compare
6 tasks
Owner
|
Closing in favor of #1253 (v0.37.7.0 fix wave) which re-implements source routing for Specifically your work informed the Per the wave's "re-implement, credit, close" workflow, your contribution is acknowledged via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two source-routing bugs:
gbrain import --source <id>now routes imported pages/chunks to the requested source using the existingresolveSourceIdchain.gbrain search --source <id>now applies a source filter in both PGLite and Postgres keyword search paths.Also:
opts.sourceIdcompatibility.--sourcevalues.Fixes #1167.
Test Plan
Local focused verification:
Manual end-to-end smoke:
GBRAIN_HOMEalpha,beta--source alpha--source betasearch --source alphaonly returns alphasearch --source betaonly returns betasearch --source defaultdoes not return imported alpha/beta hits--sourcevalue fails loudlyReal acceptance verification against local HermesClaude vault:
Search query
HermesClaude:--source hermesclaude-main: returns hits--source hermesintake: No results--source openclaw-wiki: No results--source default: No results--source __all__: returns hits