feat(auto-enrich): Phase 1 sensor + recipe scaffold#1236
Conversation
|
Reviewed locally against my brain (586K pages, 317 concept + 778 person, M365/iMessage-heavy). Phase 1 is solid — clean phase boundary, no DB writes, 9/9 pytest pass in 0.04s, architecture matches the A few smaller things worth surfacing in case any are useful: 1. Until Phase 3 starts writing
2. 3. 4. Discovery path is asserted but not exercised end-to-end. None of this blocks merge. #2 (requirements) feels like it'd be cheap to fold into this PR if you're game; #1, #3, #4 are happy to land separately or with Phase 2. Nice work landing this with no writes and tight test coverage. |
Phase 1 of the auto-enrichment recipe (sensor + scaffold).
What this PR ships
What this PR does NOT ship
Live verification
Known follow-up (Phase 1.5, not blocking)
The sensor's default candidate_pool_per_type=50 means ~200 candidates * 2 subprocesses each = ~400 gbrain calls per run. Hits 60s+ wall time on a large brain (63k pages). Phase 1.5 should add per-fetch timeout + concurrent execution or reduce default pool. Not blocking Phase 2.
Hard rule compliance
Card
Phase 1 card kn7dkpzjznxhq978fkx7r7c7kh8738tz on Mission Control board.