Skip to content

fix: add timeout to doctor frontmatter_integrity check #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garrytan-agents wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add timeout to doctor frontmatter_integrity check #1287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/commands/doctor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2972,9 +2972,13 @@ export async function runDoctor(engine: BrainEngine | null, args: string[], dbSo
// backups so it works for both git and non-git brain repos.
progress.heartbeat('frontmatter_integrity');
const fmHb = startHeartbeat(progress, 'scanning frontmatter…');
// Guard against full-brain FS walks hanging on large brains (200K+ pages).
// AbortSignal.timeout fires after 30s; scanBrainSources respects opts.signal.
const fmTimeoutMs = parseInt(process.env.GBRAIN_DOCTOR_FM_TIMEOUT_MS || '30000', 10);
try {
const { scanBrainSources } = await import('../core/brain-writer.ts');
const report = await scanBrainSources(engine);
const fmAbort = AbortSignal.timeout(fmTimeoutMs);
const report = await scanBrainSources(engine, { signal: fmAbort });
if (report.total === 0) {
const sources = report.per_source.length;
checks.push({
Expand Down Expand Up @@ -3002,10 +3006,14 @@ export async function runDoctor(engine: BrainEngine | null, args: string[], dbSo
});
}
} catch (e) {
const isTimeout = e instanceof DOMException && e.name === 'AbortError';
checks.push({
name: 'frontmatter_integrity',
status: 'warn',
message: `Could not scan frontmatter: ${e instanceof Error ? e.message : String(e)}`,
message: isTimeout
? `Frontmatter scan timed out after ${fmTimeoutMs / 1000}s (brain too large for full walk). ` +
`Run \`gbrain frontmatter validate <source-path>\` directly, or raise GBRAIN_DOCTOR_FM_TIMEOUT_MS.`
: `Could not scan frontmatter: ${e instanceof Error ? e.message : String(e)}`,
});
} finally {
fmHb();
Expand Down
Loading