Skip to content

feat(browse): add Edge/Chrome channel support via BROWSE_BROWSER=edge #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HMAKT99 wants to merge 1 commit into from
Closed

feat(browse): add Edge/Chrome channel support via BROWSE_BROWSER=edge #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions browse/src/browser-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,23 @@
*/

import { chromium, type Browser, type BrowserContext, type BrowserContextOptions, type Page, type Locator, type Cookie } from 'playwright';

/**
* Resolve browser launch options from BROWSE_BROWSER env var.
* BROWSE_BROWSER=edge uses Chromium engine with Edge channel,
* launching the user's installed Edge instead of bundled Chromium.
*/
function getLaunchOptions(headless: boolean): { headless: boolean; channel?: string; timeout?: number } {
const name = (process.env.BROWSE_BROWSER || '').toLowerCase();
const opts: any = { headless };
if (!headless) opts.timeout = 15000;
if (name === 'edge' || name === 'msedge') {
opts.channel = 'msedge';
} else if (name === 'chrome') {
opts.channel = 'chrome';
}
return opts;
}
import { addConsoleEntry, addNetworkEntry, addDialogEntry, networkBuffer, type DialogEntry } from './buffers';
import { validateNavigationUrl } from './url-validation';

Expand Down Expand Up @@ -62,7 +79,7 @@ export class BrowserManager {
private consecutiveFailures: number = 0;

async launch() {
this.browser = await chromium.launch({ headless: true });
this.browser = await chromium.launch(getLaunchOptions(true));

// Chromium crash → exit with clear message
this.browser.on('disconnected', () => {
Expand Down Expand Up @@ -464,7 +481,7 @@ export class BrowserManager {
// 2. Launch new headed browser (try-catch — if this fails, headless stays running)
let newBrowser: Browser;
try {
newBrowser = await chromium.launch({ headless: false, timeout: 15000 });
newBrowser = await chromium.launch(getLaunchOptions(false));
} catch (err: unknown) {
const msg = err instanceof Error ? err.message : String(err);
return `ERROR: Cannot open headed browser — ${msg}. Headless browser still running.`;
Expand Down