Wire getExecutionPayloadBid to the auctioneer, checking parent_hash/parent_root - #507
Open
0w3n-d wants to merge 1 commit into
Open
Conversation
This was referenced Aug 25, 2026
0w3n-d
force-pushed
the
od/gloas-step3-execution-payload-bid
branch
from
August 25, 2026 12:56
5e7384a to
1655d23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #489 (step 3 of 6)
Stacked on #503 — base branch is
od/gloas-step2-envelope-broadcast. Retarget todeveloponce #501/#503 merge.What this PR does
getExecutionPayloadBidneeds to check whether the requestedparent_rootis currently live -- that state (SlotData.payload_attributes_map) only exists inside the single-threaded auctioneer actor, reached viaAuctioneerHandle. This mirrorsget_header's existing architecture rather than the direct-trait-injection pattern step 2 used (that pattern doesn't fit here: step 2's envelope construction only needed one already-submitted payload, not live per-slot head-tracking state).Event::GetExecutionPayloadBid+AuctioneerHandle::get_execution_payload_bid, parallel toGetHeader.Context::get_execution_payload_bid: checks the request'sparent_hashagainstpayload_attributes_map, then checks that entry'sparent_beacon_block_rootmatches the request'sparent_root(the two must be compatible, i.e. from the same beacon state, per spec).NO_CONTENT.ExecutionPayloadBid/SignedExecutionPayloadBidtype aliases added tohelix_types.What this PR deliberately does not do
Never actually serves a bid -- every request currently reports "no bid available" (
NoBidPrepared, a valid spec response), whether or not the parent checks pass. Serving a real bid needs a Gloas-shaped payload store, which needs step 5's builder→relay submission wire format.max_execution_paymentenforcement is likewise not implemented: there's no value/execution_payment split to enforce it against yet, and step 4 hasn't landed the preference store. Both are next steps once step 5 lands.Tests
get_execution_payload_bid(pure function, independent of the heavyContexttype): unknown parent hash, parent root mismatch, missingparent_beacon_block_root, and matching parent (still no bid, by design) — all four reportNoBidPrepared, proving the guards actually run rather than short-circuiting.Reviewer checklist
lint,unit-test) is green