Fix needless-borrow clippy lint in header_stream.rs - #516
Open
0w3n-d wants to merge 1 commit into
Open
Conversation
cargo clippy --all-features --no-deps -- -D warnings currently fails on a clean develop checkout because of this. config is already a reference, so &config double-borrows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
`cargo clippy --all-features --no-deps -- -D warnings` -- the exact command this repo's workflow requires before any step is declared done -- currently fails on a clean `develop` checkout:
```
error: this expression creates a reference which is immediately dereferenced by the compiler
--> crates/relay/src/api/proposer/header_stream.rs:67:67
| .admit_header_stream(¶ms, &headers, &preferences, &config)
| ^^^^^^^ help: change this to:
config```
`config` is already a reference (`let config = &proposer_api.relay_config.header_stream;`), so `&config` double-borrows. One-line fix.
What this PR deliberately does NOT do
Nothing else -- found while verifying an unrelated change, unblocking clean clippy runs for everyone.
Tests
No behavior change; existing `header_stream` tests still pass.
Reviewer checklist