Stop mis-routing Gloas submissions to the Electra-shaped validation RPC - #517
Open
0w3n-d wants to merge 2 commits into
Open
Stop mis-routing Gloas submissions to the Electra-shaped validation RPC#5170w3n-d wants to merge 2 commits into
0w3n-d wants to merge 2 commits into
Conversation
sim_request_builder picked the v4 (Electra/Prague-shaped) validation method for any fork other than Fulu, including Gloas -- silently wrong now that submit_block can decode Gloas-fork submissions. Make it return None for forks it has no validation method for, and have the caller report BlockSimError::UnsupportedFork instead of dispatching. Full Gloas support in this simulator needs a validateBuilderSubmissionV6 path against a Gloas-aware EL client; tracked separately.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
`SimulatorClient::sim_request_builder` picked the validation RPC method by fork:
```rust
let method = if fork == ForkName::Fulu { &self.sim_method_v5 } else { &self.sim_method_v4 };
```
Since #514 made `submit_block` able to decode Gloas-fork submissions (unrelated to this bug -- helix's own builder-submission wire shape didn't need to change for Gloas, so nothing stopped a Gloas submission reaching this point), a Gloas submission landing here would silently fall into the `else` branch and get validated via `sim_method_v4`, the Electra/Prague-shaped RPC. Wrong, and silent about it.
What this PR deliberately does NOT do
Does not add real Gloas validation support to `helix-simulator` -- that needs a Gloas-aware EL client (reth has no Amsterdam/ePBS support in its tagged release yet, only on a devnet branch) and a new `validateBuilderSubmissionV6` path. Tracked as its own issue.
Tests
Written before implementation:
Reviewer checklist