remove allocation on outbound gossip - #202
Merged
Merged
Conversation
vladimir-ea
marked this pull request as ready for review
August 26, 2026 10:07
alexX512
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QUIC stack copies all outbound data into ack buffers in case it needs to resend. This change removes those allocations for outbound gossip - instead we pass in tcache references.
This requires that the tcache data lives until the sent data is acked and must not be released. The default
RandomAccessConsumeris not strict in this regard and can release acquired data if it falls behind; so this PR adds a 'strict' mode where this behaviour is not allowed. Only used currently on the outbound gossip consumer.