Configure Nigeria static site to use configurations from files - #13
Open
wcyn wants to merge 22 commits into
Open
Configure Nigeria static site to use configurations from files#13wcyn wants to merge 22 commits into
wcyn wants to merge 22 commits into
Conversation
* If "has_error" not set, assume gazette is okay * Also added gazettes from 1906 - 2006
…into develop Sync develop with master
Add configuration variables to jekyll static site
DavidLemayian
suggested changes
Jul 11, 2017
| AWS_ACCESS_KEY_ID= | ||
| AWS_SECRET_ACCESS_KEY= | ||
| BUCKET="opengazettes.or.ke" | ||
| BUCKET="http://opengazettes.or.ng" |
There was a problem hiding this comment.
Is the bucket a URL? Let's also call this S3_BUCKET to be even more clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds the generic configuration settings to the
nigeriabranch to reduce hard coding of valuesChanges Made
developdevelopbranch for automation)Challenges
Trello Card Link
https://trello.com/c/YAnvBqov/11-ng-set-up-static-site