This repository was archived by the owner on Feb 26, 2026. It is now read-only.
RT84075: Date::Parse::str2time maps date in 1963 to 2063#8
Open
perlpilot wants to merge 2 commits intogbarr:masterfrom
Open
RT84075: Date::Parse::str2time maps date in 1963 to 2063#8perlpilot wants to merge 2 commits intogbarr:masterfrom
perlpilot wants to merge 2 commits intogbarr:masterfrom
Conversation
If we've been given a year that's got the century attached (i.e., the year is > 1900), store the century. Then use this information to defeat the guessing behavior of timegm.
Migration NoticeThis repository is no longer actively maintained. The official source has moved to atoomic/perl-TimeDate. This PR's changes have already been incorporated into the new repository. No migration needed. 🤖 Automated migration check by Kōan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test and a fix for this bug. The guess in RT that the bug is triggered in years that are 50 years in the past is good. str2time makes calls to timegm/timelocal which have some guessing logic for the century when given 2 digit years. To fix the bug, we keep track of whether or not we were given a 4 digit year and if so, pass a 4 digit year to timegm/timelocal so it doesn't guess.