fix(terminal): dispose grouped session when tmux attach fails#160
Open
dsfaccini wants to merge 2 commits into
Open
fix(terminal): dispose grouped session when tmux attach fails#160dsfaccini wants to merge 2 commits into
dsfaccini wants to merge 2 commits into
Conversation
doStart creates the grouped …-ws-<uuid> session before spawning tmux attach. If that spawn throws, tear the session down via dispose() instead of only marking DEAD — otherwise the orphan holds a pty until the next restart reaper.
package.json optionalDependencies were bumped to 0.4.4 but bun.lock still listed 0.4.3, so `bun install --frozen-lockfile` fails on CI (and locally).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was posted by AICA on behalf of David.
Summary
PtyTerminalProxy.doStartcreates the grouped…-ws-<uuid>session before spawningtmux attach.DEADand rethrow without tearing the grouped session down.await this.dispose()on the attach-spawn failure path, matching the other error/cancel paths indoStart.kill-sessionon the grouped session name.Test plan
bun test src/server/__tests__/isolated/terminalProxy.test.ts(13 pass, including new case)