build(deps): bump cryptography from 49.0.0 to 50.0.0 - #26
Conversation
gcalpay
left a comment
There was a problem hiding this comment.
Technical review context for follow-up verification; no approval or merge decision is being made here.
I reviewed the current diff, current CI state, and the upstream cryptography 50.0.0 changelog. This PR is lockfile-only, but it is a major-version update and therefore deserves more scrutiny than an ordinary patch bump.
The direct resolved dependency changes are:
cryptography49.0.0 -> 50.0.0- marker changes around
cffi/pycparser - additional marker normalization for transitive packages such as
importlib-metadata,scipy, andsecretstorage
Current PR-head CI is fully green: Verify, CodeQL, and Dependency audit all completed successfully.
Important upstream context:
- cryptography 50.0.0 fixes CVE-2026-69247, a PKCS#7 decryption side-channel/Bleichenbacher-oracle issue
- finite-field Diffie-Hellman APIs are deprecated
- several X.509/DER/OCSP parsing paths become stricter
- the release includes other API additions and backend changes
The security fix is a reason in favor of moving forward, but the major-version boundary means the absence of failing tests is not sufficient by itself. Codex should verify whether Carnopy directly imports cryptography at all or receives it only transitively, identify which top-level package pulls it into the lockfile, and confirm that Carnopy does not rely on deprecated FFDH APIs or on parsing behavior that is intentionally stricter in 50.0.0. It should also verify that the lockfile marker changes are expected consequences of the new metadata rather than unrelated resolution churn.
I found no blocking defect in the current diff or CI, and no source files are changed. If Codex confirms that cryptography is only a compatible transitive dependency (or that any direct use avoids the affected deprecated/stricter APIs), this update has a strong case because it carries a security fix. Do not merge solely on that basis without the dependency-path check.
|
@dependabot rebase |
Bumps [cryptography](https://github.com/pyca/cryptography) from 49.0.0 to 50.0.0. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@49.0.0...50.0.0) --- updated-dependencies: - dependency-name: cryptography dependency-version: 50.0.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
c1743ec to
42a9ff3
Compare
Bumps cryptography from 49.0.0 to 50.0.0.
Changelog
Sourced from cryptography's changelog.
... (truncated)
Commits
dcb7050Prepare for 50.0.0 release (#15372)53fccd9Don't leak how PKCS#7 encryptedKey decryption failed (#15369)d472f97Addfrom __future__ import annotationsto all src/ Python files (#15371)908773dBump downstream dependencies in CI (#15368)2cc07ccBump BoringSSL, OpenSSL, AWS-LC in CI (#15367)c94ede9chore(deps): bump ruff from 0.16.0 to 0.16.1 (#15366)67a8308chore(deps): bump virtualenv from 21.7.0 to 21.7.1 (#15365)95018ffRelease the GIL in one-shot AEAD encrypt/decrypt (#15361)6954733Release the GIL during DH and DSA parameter generation (#15364)6893b94Import _serialization instead of serialization in x509/extensions (#15363)