Skip to content

Improve/code quality - #22

Merged
gchamon merged 4 commits into
mainfrom
improve/code-quality
Apr 24, 2026
Merged

gchamon merged 4 commits into
mainfrom
improve/code-quality

Conversation

@gchamon

@gchamon gchamon commented Apr 24, 2026

Copy link
Copy Markdown
Owner
  • fix issues presented by sonarcloud (reduce cognitive complexity by extracting helpers in curator.py,
    dav_app.py, subtitles.py, state.py, ui_live.py, dav_protocol.py; extract duplicated string literals
    into named constants in models.py/dav_app.py; use resp.read() instead of pass on urlopen; switch
    assertTrue(a > b) to assertGreater; drop _strip_secrets nested complexity into _strip_provider_token /
    _strip_opensubtitles_secrets)
  • reimplement marquee-on-hover (plus add a work-item note under work-items/ and test coverage
    asserting the BuzzOverflowMarquee hook renders on archive/cache pages)
  • consolidate Dockerfile RUN layers (merge the bootstrap mkdir/touch into the uv pip install layer)
  • minor typing cleanups (e.g. Any import in dav_app.py, explicit set[str] annotations in curator.py)

@gchamon gchamon mentioned this pull request Apr 24, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
59.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@gchamon
gchamon merged commit ff6f8f2 into main Apr 24, 2026
6 of 7 checks passed
@gchamon
gchamon deleted the improve/code-quality branch April 24, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant