Refactor benchmark solver setup - #1247
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
sylvesterkaczmarek
marked this pull request as ready for review
September 11, 2026 09:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Description
Closes #1002.
Consolidate benchmark solver construction in
coreax.benchmark_util, while preserving benchmark-specific calibration. Reuse the calibrated Stein kernel within one benchmark registry, make visualiser output paths independent of the current working directory, and correct the blobs benchmark so the random seed is not passed as the thinning failure probability.The contributor guide now documents the benchmark workflow and the settings that must remain comparable across runs.
How Has This Been Tested?
21focused benchmark tests passed.1,753 passed, 19 skipped.10.00/10.-n -W.Does this PR introduce a breaking change?
No. Existing public solver interfaces are unchanged.
Checklist before requesting a review