refactor: modularize architecture with test coverage - #1
Open
ShadowoftheRavens wants to merge 2 commits into
Open
ShadowoftheRavens wants to merge 2 commits into
ShadowoftheRavens wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the 7th Sea Dice Roller application from a monolithic structure into a modular, layered architecture with comprehensive test coverage.
Changes
Architecture Refactoring
Modularization: Split
app.mjsinto 5 focused modules:controller.mjs- Event binding and action dispatchrenderer.mjs- DOM rendering and markup generationapp-state.mjs- State shape and mutationsdice-service.mjs- Dice rolling and explosion mechanicsapp-logic.mjs- Partition search algorithm and game logicStyling: Extracted all CSS into
styles.cssfor separation of concernsConstants: Created
constants.mjswith centralized:Algorithm Improvements
Test Coverage
Validation
How to Test
Run the regression test suite: