ci: GitHub Actions (CI Ruby 2.7 + release a RubyGems) - #18
Merged
Conversation
…Travis - main.yml: corre rspec en PRs y push a master sobre Ruby 2.7 (savon 2.12 / httpi 2.x no corre en Ruby 3.0+; el consumer wispro_cloud usa 2.7.6). - release.yml: build + push a RubyGems en tag v* (secret RUBYGEMS_API_KEY). - gemspec: declarar rspec (~> 3.13) —faltaba, la suite no corría—; quitar el pin de bundler (~> 2.6.6 exige Ruby 3.1+, choca con 2.7); required_ruby_version >= 2.7. - Eliminar .travis.yml legacy (Ruby 1.8.7). Adaptado del workflow de bug_bunny/snoopy_afip al stack de este repo. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Review multi-vendor (agy + opencode): - release.yml: usar GEM_HOST_API_KEY nativo en vez de escribir ~/.gem/credentials con printf (no persiste el secreto en disco ni en el process list del runner). - release.yml: ruby-version 3.2 -> 2.7 para alinear con CI y el constraint de savon (gem build evalúa el gemspec con el Ruby del runner). - release.yml: quitar `packages: write` (least-privilege; se pushea a RubyGems, no a GHCR) y encadenar gem build && gem push. - gemspec: required_ruby_version `>= 2.7` -> `['>= 2.7', '< 3.0']` para honrar la incompatibilidad declarada con Ruby 3.0+. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…pec explícito Review multi-vendor r2 (opencode): - main.yml: agregar `permissions: contents: read` (simetría con release.yml). - release.yml: `persist-credentials: false` en checkout (defense-in-depth). - release.yml: `gem build cobro_digital.gemspec` explícito (no wildcard). Refutados: checkout@v5 "inexistente" (existe; lo usan bug_bunny/snoopy en CI activa) y "bundler sin mención" (sí está en el commit previo). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
🤖 Review multi-vendor (opencode
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agrega CI + release tag-driven, adaptando el workflow de
bug_bunny/snoopy_afipal stack de este repo.Workflows
main.yml— correbundle exec rspecen PRs y push amaster, sobre Ruby 2.7.release.yml—gem build+gem pusha RubyGems en tagv*(secretRUBYGEMS_API_KEY). Idéntico a bug_bunny/snoopy (Ruby 3.2, solo build+push).Adaptaciones propias de cobro_digital (no es copy-paste)
savon ~> 2.12.1→ httpi 2.x usaURI.escape, removido en Ruby 3.0. El único consumer (wispro_cloud) corre Ruby 2.7.6 concobro_digital ~> 1.8.0.rspec ~> 3.13al gemspecbundle exec rspecfallaba (rspec fuera del bundle). Bloqueante real.bundler ~> 2.6.6required_ruby_version >= 2.7.travis.ymlNotas
bundler-cache: truesinGemfile.lockversionado → setup-ruby lo resuelve/genera en CI.🤖 Generated with Claude Code