Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent inactive lanes in the fixed-width JAX diagonal sweep from overflowing and poisoning native JAX gradients. The final kernel value can be finite while unused internal states produce NaNs during backpropagation; outer gradient clipping cannot fix that.
wherefor boundary selection.self.exponentsinside the jitted single-pair entry point, which leaked a tracer on reuse in the new differentiation tests.No custom-VJP implementation is imported from another repository. No dataset samples, learned weights, preprocessing changes, gradient clipping changes, or dtype changes are included. Real active-tile overflow remains visible.
Validation
pytest tests/test_core_jax.py tests/test_diagonal_masking.py -q— 46 passed.pytest tests/test_diagonal_masking.py -q— 25 passed; strict FP32, highest matmul precision,NVIDIA_TF32_OVERRIDE=0.See
docs/diagonal-masking.mdfor the numerical rationale and stress-test tolerance.