Do not fail if state is not started - #13
Open
jaypee-solutions wants to merge 1 commit into
Open
Conversation
jaypee-solutions
force-pushed
the
jp/no-fail
branch
2 times, most recently
from
February 24, 2022 16:46
412c044 to
833e2bb
Compare
When using node_exporter_state stopped the role will fail, while nodeexporter is expected to not respond.
jaypee-solutions
force-pushed
the
jp/no-fail
branch
from
February 24, 2022 16:54
833e2bb to
98f7fdb
Compare
|
I would like to request this also. - role: geerlingguy.node_exporter
become: true
node_exporter_state: stopped
node_exporter_enabled: falseit uninstalls the service indeed, getting: systemctl status node_exporter
● node_exporter.service - NodeExporter
Loaded: loaded (/etc/systemd/system/node_exporter.service; disabled; vendor preset: enabled)
Active: inactive (dead)but it indeed errors out the |
|
Not trying to rush here or anything, but this pull request is on "planned" since 2022. 😉 I would really love to see this feature added. |
|
My last comment also should have referenced issue #28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using node_exporter_state stopped the role will fail,
while nodeexporter is expected to not respond.