coru_platform [ARM]: fix for Wincompatible-pointer-types warning#4
Open
maximevince wants to merge 1 commit intogeky:masterfrom
Open
coru_platform [ARM]: fix for Wincompatible-pointer-types warning#4maximevince wants to merge 1 commit intogeky:masterfrom
maximevince wants to merge 1 commit intogeky:masterfrom
Conversation
Owner
|
Looks good to me, thanks for this! Hmm, I'm not sure why CI is failing, it looks unrelated (I arm-none-eabi-gcc was updated?). I will fix that first and then bring this in. |
geky
approved these changes
Jan 6, 2021
|
Any update on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi geky,
I have found one of your other nice little projects :)
I propose a small fix in this pull request, since I noticed that my ARM GCC compiler was generating the following warning:
The warning should be harmless, since it's only converting between pointers to a long unsigned integer on the one hand and an unsigned integer on the other hand, but I figured you might want to have this warning fixed anyway.