Fix Windows-only engine CI failures - #6
Merged
Merged
Conversation
Skip Unix +x checks on Windows hosts when resolving foreign engine binaries, quote each thin-launcher argv token for cmd.exe paths with spaces, and normalize CRLF before self-contained live-setup projection so Validate stays green on windows-2025 without changing POSIX hosts. Co-authored-by: Dennis Geldmacher <geldmacher.dennis@outlook.de>
geldmacher
marked this pull request as ready for review
September 9, 2026 11:41
…ract Node was re-escaping the carefully quoted cmd.exe /s /c line, so plugin paths with spaces still became a UNC-looking fragment. Pass windowsVerbatimArguments for Windows launcher spawns, resolve the thin .cmd through an absolute PLUGIN_ROOT, and normalize CRLF before the portable host-contract projection so Validate can finish on windows-2025. Co-authored-by: Dennis Geldmacher <geldmacher.dennis@outlook.de>
The last Windows engine failure was host.mjs lifecycle notation: the search includes a literal LF before `}`, so autocrlf checkouts missed the anchor. Normalize CRLF inside replaceRequired so every portable projection match is newline-tolerant. Co-authored-by: Dennis Geldmacher <geldmacher.dennis@outlook.de>
The hardened launcher set PLUGIN_ROOT to the package root, which made resolveHost always treat Windows runs as Codex. Candidate context then emitted PLUGIN_HOOK_STATE: codex: while checks expected agent-plugin or cursor. Rename the launcher var to DESIGN_LAUNCHER_ROOT, and normalize CRLF in engine projection and candidate context checks. Co-authored-by: Dennis Geldmacher <geldmacher.dennis@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows-only
engine (windows-2025)failures after the package-structure simplification are fixed. Full Validate is green onb0c468bincluding Windows.Root causes
resolveEnginechecked Unix+xbased on the requested engine platform, so foreign binaries failed on Windows where Git/NTFS drop execute bits.cmd.exe /s /cargv; fixed withwindowsVerbatimArgumentsand absolute launcher root resolution.live-setup, host contract,host.mjslifecycle notation) missed under autocrlf; normalize CRLF inreplaceRequired/ projection reads..cmdPLUGIN_ROOTcollision — hardened launcher setPLUGIN_ROOT, which maderesolveHostalways treat Windows runs as Codex, so candidate context emittedPLUGIN_HOOK_STATE: codex:while checks expectedagent-plugin/cursor. Renamed toDESIGN_LAUNCHER_ROOT.Evidence
engine (windows-2025)— successNo release/tag.